Skip to content

Commit

Permalink
Fixes based on addition of acceptable-values
Browse files Browse the repository at this point in the history
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
  • Loading branch information
Anthony Emengo committed Jul 22, 2021
1 parent d3e6575 commit 0f50d69
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
3 changes: 1 addition & 2 deletions 0000-template.md
Expand Up @@ -3,8 +3,7 @@
- Name: (fill in the feature name: My Feature)
- Start Date: (fill in today's date: YYYY-MM-DD)
- Author(s): (Github usernames)
<!-- Acceptable values: Approved, On Hold, Draft` -->
- Status: Draft
- Status: Draft <!-- Acceptable values: Approved, On Hold, Draft -->
- RFC Pull Request: (leave blank)
- CNB Pull Request: (leave blank)
- CNB Issue: (leave blank)
Expand Down
2 changes: 1 addition & 1 deletion merge-rfc.sh
Expand Up @@ -75,7 +75,7 @@ TARGET=${SOURCE//0000/$(printf "%04d" "${ID}")}

sed -i '' "s|- RFC Pull Request:.*|- RFC Pull Request: [rfcs#${PR}](https://github.com/buildpacks/rfcs/pull/${PR})|" "${SOURCE}"
sed -i '' "s|- CNB Issue:.*|- CNB Issue: $issues|" "${SOURCE}"
sed -i '' "s,- Status:.*,- Status: **Approved** | On Hold," "${SOURCE}"
sed -i '' "s|- Status:.*|- Status: Approved|" "${SOURCE}"
git mv "${SOURCE}" "${TARGET}"
git add "${TARGET}"
git commit --signoff --message "RFC ${ID}
Expand Down
11 changes: 6 additions & 5 deletions text/0000-add-status-field.md
Expand Up @@ -3,7 +3,7 @@
- Name: Add Status to RFC Metadata
- Start Date: 2021-07-14
- Author(s): @aemengo, @ekcasey
- Status: Approved | On Hold
- Status: Draft <!-- Acceptable values: Approved, On Hold, Draft -->
- RFC Pull Request: (leave blank)
- CNB Pull Request: (leave blank)
- CNB Issue: (leave blank)
Expand All @@ -30,30 +30,31 @@ This RFC formally introduces the **"On Hold"** status for an RFC, in a way that'
A new `Status:` field in the `Meta` section of the RFC template. See [#meta](#meta) for example.

The acceptable values are distinguished in the following ways:
- **Draft**: The Core team has not yet approved the RFC. Edits are still being made.
- **Approved**: The Core team has approved the RFC and is accepting PRs for its implementation.
- **On Hold**: The Core team has approved the RFC, but PRs are currently not being accepted for its implementation. A reason must be provided in the RFC.

The `Status:` field does not intend to reflect states that are already implied by the RFC process. Examples including: *Draft*, *In Review*, *Closed*, etc.
The `Status:` field does not intend to reflect states that are already implied by the RFC process. Examples including: *In Review*, *Closed*, etc.

# How it Works
[how-it-works]: #how-it-works

We will add the following to the RFC `Meta` section template:

```
- Status: Approved | On Hold
- Status: Draft <!-- Acceptable values: Approved, On Hold, Draft -->
```

When an RFC is approved, the [../merge-rfc.sh](../merge-rfc.sh) script reflects the change like so:

```
- Status: **Approved** | On Hold
- Status: Approved
```

When an RFC is put on hold (_via Pull Request_) then change is reflected like so:

```
- Status: Approved | **On Hold**
- Status: On Hold
```

# Drawbacks
Expand Down

0 comments on commit 0f50d69

Please sign in to comment.