RFC issue generation #141
RFC issue generation #141
Conversation
Signed-off-by: Javier Romero <rjavier@vmware.com>
|
🙏 |
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
|
I really like the comments idea. What are people's thoughts on making that the proposal vs. the alternative? |
text/0000-rfc-issue-generation.md
Outdated
|
|
||
| ##### Cons | ||
|
|
||
| - No call-to-action for maintainers. The maintainers would have to remember to do this during their review. |
There was a problem hiding this comment.
Perhaps the RFC merge script could fail if it detects a total of 0 net issues created.
There was a problem hiding this comment.
I'm not sure this would be a healthy check to impose. Looking through some RFCs, in particular those related to process or governance changes, it's unclear that any issues should be created. If we think hard enough, if only to satisfy the requirement, I'm sure we can find some issue to create but not sure it's the best approach.
Some examples:
- https://github.com/buildpacks/rfcs/blob/main/text/0071-cnb-user-research-2021.md
- https://github.com/buildpacks/rfcs/blob/main/text/0062-distribution-team.md
- https://github.com/buildpacks/rfcs/blob/main/text/0060-create-repo-issues.md
- https://github.com/buildpacks/rfcs/blob/main/text/0059-label-rfcs.md
I'm going to make that the primary proposal. |
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
This has been done. @buildpacks/core-team please re-review. |
| > _(none)_ | ||
| > | ||
|
|
||
| Once the RFC is merged via the [`merge-rfc.sh`](https://github.com/buildpacks/rfcs/blob/main/merge-rfc.sh) script, the script could detect issues by looking through the top comment from the _bot_ and creating any queued issues. Some additions that the script may do but subject to change: |
There was a problem hiding this comment.
I assume this could be done via a GitHub action on PR merges?
There was a problem hiding this comment.
At a later point in time or via separate initiative, yes.
|
FCP closing 4/14/21 |
Signed-off-by: Javier Romero <rjavier@vmware.com> Co-authored-by: Anthony Emengo <anthonyemengojr@gmail.com>
|
@jromero to help with issue creation |
|
Merged this RFC. |
Rendered