Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Export to OCI format #203

Merged
merged 63 commits into from Mar 7, 2023
Merged

RFC: Export to OCI format #203

merged 63 commits into from Mar 7, 2023

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Feb 23, 2022 •
edited

Resolves #197

Readable

Signed-off-by: Juan Bustamante jbustamante@vmware.com

Note

This RFC was initially proposed as a mechanism for removing the Daemon in the near future, in order to do that, a high level plan I proposed is as follows.

  • Approve this RFC and add the export to OCI layout format feature in Lifecycle
  • Implement in Pack a new workflow when the -daemon flag is enabled based on what we did with the PoC. The workflow could be enabled by the user in experimental mode
    • Make noise in the community so people can help us using it
    • Collect feedback about it
    • Correct issues until we feel confortable
  • Turn off the actual -daemon implementation and replace it with the -oci by default in Pack
    • Maybe we can also add a new flag to re-use the old implementation in case the user needs it
    • Keep doing noise in the community
    • Collect feedback about it
    • Correct issues until we feel confortable
  • Schedule the removal of the Daemon support in Lifecycle version X.Y.Z.
  • Remove the actual daemon support from the code base for Lifecycle version X.Y.Z

I am not 100% we will remove the daemon support, but at least, I want to left this plan here to do not lose it.

@buildpack-bot
Copy link
Member

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

@jjbustamante jjbustamante changed the title Add Publish operation RFC: Add Publish operation Feb 23, 2022
@natalieparellano natalieparellano mentioned this pull request Feb 25, 2022
Open
@jromero jromero mentioned this pull request Mar 1, 2022
Draft
@jjbustamante jjbustamante changed the title RFC: Add Publish operation RFC: Export to OCI format when Daemon is enabled Mar 2, 2022
@jjbustamante jjbustamante force-pushed the jjbustamante/feature/publish-operation branch 2 times, most recently from 5aa8dbb to d1412b8 Compare March 4, 2022 22:09
@jjbustamante jjbustamante changed the title RFC: Export to OCI format when Daemon is enabled RFC: Export to OCI format Mar 9, 2022
@jjbustamante jjbustamante mentioned this pull request Mar 16, 2022
Open
@natalieparellano natalieparellano mentioned this pull request Apr 14, 2022
Closed
@jromero jromero self-assigned this Jun 1, 2022
@jjbustamante jjbustamante mentioned this pull request Jun 2, 2022
Closed
jjbustamante and others added 14 commits February 13, 2023 12:49
@jjbustamante
removing the plan for daemon removal
f9e225f 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
adding the possibility to allow partial images on disk
f79bb23 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
extending the examples section
966488a 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante @natalieparellano
Update text/0000-export-to-oci.md
9eb99ad 
Fixes suggested by Natalie

Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
renaming flags to use layout instead of oci
e6e01fd 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Adding updates after the implementation
a38c474 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Adding updates after the implementation
f498b0a 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Open questions
5d9b008 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Unresolved question about exporting to tarball
6fc05ff 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
updating the rules to map image ref to path
40cd649 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Removing the Name field from the analyzed.toml
1771f9f 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
removing the layout-repo flag
35bd3e9 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Revert "Removing the Name field from the analyzed.toml"
eba5b7e 
This reverts commit 9e5c2d0.

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
adding Natalie's feedback
1086f45 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante force-pushed the jjbustamante/feature/publish-operation branch from fda5263 to 1086f45 Compare February 13, 2023 17:51
@jjbustamante jjbustamante mentioned this pull request Feb 13, 2023
Closed
4 tasks
@jjbustamante
adding layout-dir to some missing places
b09fea0 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Merge branch 'main' into jjbustamante/feature/publish-operation
d5cbf7d
@jjbustamante
updating the unresolved questions
76d034f 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
updating the spec changes
77c9fcc 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Update 0000-export-to-oci.md
8beb9e8 
Fixing error message according to the implementation

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@natalieparellano
Copy link
Member

Moving to status/voting closing next Wednesday 2/29

@jjbustamante
Copy link
Member Author

Moving to status/voting closing next Wednesday 2/29

@natalieparellano can we merge this PR?

natalieparellano added a commit that referenced this pull request Mar 7, 2023
@natalieparellano
RFC 0119
49f1700 
[#203]

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano merged commit a221679 into main Mar 7, 2023
@natalieparellano natalieparellano deleted the jjbustamante/feature/publish-operation branch March 7, 2023 21:02
@jjbustamante jjbustamante mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero left review comments

@jabrown85 jabrown85 jabrown85 approved these changes

@Choobz Choobz Choobz left review comments

@jkutner jkutner jkutner approved these changes

@natalieparellano natalieparellano natalieparellano approved these changes

Assignees

@natalieparellano natalieparellano

Labels
scope/project status/voting team/platform type/rfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: Add support for OCI layout / deprecate daemon support
9 participants
@jjbustamante @buildpack-bot @natalieparellano @samj1912 @jkutner @jromero @jabrown85 @Choobz @dfreilich