Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Remove -helpers flags from lifecycle #48

Merged
merged 3 commits into from
Feb 24, 2020
Merged

RFC: Remove -helpers flags from lifecycle #48

merged 3 commits into from
Feb 24, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Jan 24, 2020

thisisnotashwin
thisisnotashwin reviewed Jan 24, 2020
View reviewed changes
text/0000-remove-cred-helpers.md Outdated Show resolved Hide resolved
text/0000-remove-cred-helpers.md Outdated Show resolved Hide resolved
@nebhale
Copy link
Contributor

nebhale commented Jan 29, 2020

Want to give a big deprecation notice before doing the work.

hone
hone approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@hone hone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything where we want extra input from the community, I believe we shouldn't short circuit this and it should go through the FCP.

@zmackie
Copy link
Contributor

zmackie commented Jan 30, 2020 •
edited
Loading

buildpacks/samples would need cred helpers removed

@zmackie zmackie mentioned this pull request Feb 3, 2020
Closed
@zmackie
Copy link
Contributor

zmackie commented Feb 6, 2020 •
edited
Loading

@jkutner To discuss with @jamesward

@zmackie
Copy link
Contributor

zmackie commented Feb 13, 2020 •
edited
Loading

Consensus: we're going to move forward.

@nebhale
Copy link
Contributor

nebhale commented Feb 14, 2020

I move that this RFC be sent to FCP with a disposition of merge, closing 1700 PT, February 21, 2019.

@ekcasey ekcasey mentioned this pull request Feb 21, 2020
Merged
@ekcasey ekcasey requested a review from a team as a code owner February 21, 2020 23:36
ekcasey and others added 3 commits February 24, 2020 09:02
@ekcasey @nebhale
RFC to remove -helpers flags from lifecycle
e6779cc 
Signed-off-by: Emily Casey <ecasey@pivotal.io>
Signed-off-by: Ben Hale <bhale@pivotal.io>
@ekcasey @nebhale
typo fixes
5f88fad 
Signed-off-by: Emily Casey <ecasey@pivotal.io>
Signed-off-by: Ben Hale <bhale@pivotal.io>
@nebhale
RFC #28
788c1fd 
[resolves #48]

Signed-off-by: Ben Hale <bhale@pivotal.io>
@nebhale nebhale closed this in 788c1fd Feb 24, 2020
@nebhale nebhale deleted the remove-cred-helpers-support branch February 24, 2020 17:03
@nebhale nebhale merged commit 6b9b258 into master Feb 24, 2020
zmackie pushed a commit to zmackie/rfcs that referenced this pull request Mar 30, 2020
@nebhale @zmackie
RFC buildpacks#28
295ceca 
[resolves buildpacks#48]

Signed-off-by: Ben Hale <bhale@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin left review comments

@jkutner jkutner jkutner approved these changes

@hone hone hone approved these changes

@nebhale nebhale nebhale approved these changes

@sclevine sclevine Awaiting requested review from sclevine

Assignees
No one assigned
Labels
team/implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ekcasey @nebhale @zmackie @jkutner @hone @thisisnotashwin