Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

Use non-red (or red-like) hues for all non-error output. #40

Closed
sclevine opened this issue Jan 23, 2019 · 3 comments
Closed

Use non-red (or red-like) hues for all non-error output. #40

sclevine opened this issue Jan 23, 2019 · 3 comments
Labels

Comments

@sclevine
Copy link
Member

sclevine commented Jan 23, 2019

These hues should only be used to draw attention to errors.

Acceptance Criteria
When I execute any pack subcommand
Then I only see red or red-like hues for error output

@sclevine sclevine created this issue from a note in Planning Board (Backlog) Jan 23, 2019
@mgibson1121
Copy link
Member

mgibson1121 commented Jan 28, 2019

When I execute a command successfully using the pack CLI (an error does not occur)
Then I see green non error output text styled in green

Notes

  • Green won the styling survey based on seven responses. I also think green looks the best and leaves the least room for ambiguity.

  • It is my understanding that tip text is styled in green. We should monitor if this turns into a UX problem in the future. If it does, I would recommend changing the tip text to yellow

  • The color can be modified by going into pack/style/style.go and changing var Key = color.MagentaStringto var Key = color.GreenString

ekcasey added a commit to buildpacks/pack that referenced this issue Mar 27, 2019
* magenta gave the false impression of an errors b/c it looked too much like red

[buildpacks/roadmap#40]

Signed-off-by: Emily Casey <ecasey@pivotal.io>
@ekcasey ekcasey moved this from Backlog to Done in Planning Board Mar 27, 2019
@ekcasey
Copy link
Member

ekcasey commented Mar 27, 2019

delivered in pack-0.1.0-build.70-darwin

@mgibson1121
Copy link
Member

@ekcasey @ameyer-pivotal Tested this out in pack-0.1.0-build.70-darwin. Output is green. Per my discussion with @ameyer-pivotal Wednesday morning, he felt pretty strongly that the output color should be a normal shade that is bolded. Although green won the survey, I differ to him. @ameyer-pivotal do you want me to reject and rewrite the ticket?

@sclevine sclevine moved this from Done to Release v0.1.0 in Planning Board Mar 28, 2019
@sclevine sclevine closed this as completed Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants