You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
When I execute a command successfully using the pack CLI (an error does not occur) Then I see green non error output text styled in green
Notes
Green won the styling survey based on seven responses. I also think green looks the best and leaves the least room for ambiguity.
It is my understanding that tip text is styled in green. We should monitor if this turns into a UX problem in the future. If it does, I would recommend changing the tip text to yellow
The color can be modified by going into pack/style/style.go and changing var Key = color.MagentaStringto var Key = color.GreenString
ekcasey
added a commit
to buildpacks/pack
that referenced
this issue
Mar 27, 2019
* magenta gave the false impression of an errors b/c it looked too much like red
[buildpacks/roadmap#40]
Signed-off-by: Emily Casey <ecasey@pivotal.io>
@ekcasey@ameyer-pivotal Tested this out in pack-0.1.0-build.70-darwin. Output is green. Per my discussion with @ameyer-pivotal Wednesday morning, he felt pretty strongly that the output color should be a normal shade that is bolded. Although green won the survey, I differ to him. @ameyer-pivotal do you want me to reject and rewrite the ticket?
These hues should only be used to draw attention to errors.
Acceptance Criteria
When I execute any
pack
subcommandThen I only see red or red-like hues for error output
The text was updated successfully, but these errors were encountered: