Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run image ENTRYPOINT should be specified in the stack's run image, not by the exporter #15

Closed
sclevine opened this issue Oct 15, 2018 · 4 comments
Assignees

Comments

@sclevine
Copy link
Member

We should remove this: https://github.com/buildpack/spec/blob/master/buildpack.md#phase-4-export
And add a section to the platform spec describing how the stack sets ENTRYPOINT.

(We should change this back if we ever make the export phase responsible for copying the launch-responsible lifecycle component to the final image.)

@nebhale
Copy link
Contributor

nebhale commented Oct 15, 2018

Concur. Seems like it's generic enough that baking it into the stack rather than requiring it as part of each and every export is the way to do it. Seems like the right part of the spec as well, not just an implementation detail of how we handle it.

@nebhale
Copy link
Contributor

nebhale commented Oct 16, 2018

In the name of consistency between the builder and the launcher in the image that was created, launcher should be contributed by and the ENTRYPOINT set by the builder.

@nebhale
Copy link
Contributor

nebhale commented Oct 16, 2018

Requesting @sclevine submit a PR with spec changes.

@sclevine sclevine self-assigned this Oct 17, 2018
@sclevine
Copy link
Member Author

This was implemented in the lifecycle and intentionally left unspecified.

sclevine added a commit that referenced this issue Jul 24, 2019
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
sclevine added a commit that referenced this issue Jul 24, 2019
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
sclevine added a commit that referenced this issue Aug 4, 2019
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants