Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding launch and build booleans as top-level keys in the build plan #22

Closed
sclevine opened this issue Oct 26, 2018 · 2 comments

Comments

@sclevine
Copy link
Member

This convention seems to be used used universally.

@nebhale
Copy link
Contributor

nebhale commented Oct 29, 2018

I wouldn't say universally. I think they can be used in buildpacks that contribute to both launch and build, but I don't consider that to be a large percentage of the total population of buildpacks. They're a large percentage today, but that's skewed by the fact that we've implemented a bunch of runtime buildpacks, and almost none of the other types. In the Java realm alone, only 25% of buildpacks require it today and when we're done ~2.5% will require it.

@sclevine
Copy link
Member Author

After hearing your feedback in the WG meeting today, I no longer think we should add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants