Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows buildpacks #121

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Windows buildpacks #121

merged 2 commits into from
Jul 29, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Jul 28, 2020

Move windows buildpacks changes from platform/0.4 to buildpack/0.4

Resolves #119

Micah Young and others added 2 commits July 28, 2020 19:27
- Default Windows shell is Command Prompt (cmd.exe)
- Lifecycle binaries on Windows can be `.exe` or `.bat`
- Buildpack binaries on WIndows can be `.exe` or `.bat`
- Profile scripts are Batch Script (.bat) format
- Processes started with `direct = false` are loaded with Command Prompt
- CNB_*IDs should be SIDs on Windows
- Bash/Command Prompt reference global shell definition
- Generic Stdout/Stderr

[#62]

Signed-off-by: Micah Young <myoung@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
Signed-off-by: Ben Hale <bhale@pivotal.io>
Signed-off-by: Emily Casey <ecasey@vmware.com>
- Clean up general Windows caveats
- Simplify OS-specifics on env var table

[#62]

Signed-off-by: Micah Young <ymicah@vmware.com>
Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
Signed-off-by: Ben Hale <bhale@pivotal.io>
Signed-off-by: Emily Casey <ecasey@vmware.com>
@ekcasey ekcasey requested a review from a team as a code owner July 28, 2020 23:28
@ekcasey ekcasey added this to the Buildpack 0.4 milestone Jul 29, 2020
@ekcasey ekcasey linked an issue Jul 29, 2020 that may be closed by this pull request
@nebhale nebhale requested a review from a team July 29, 2020 14:01
@nebhale nebhale merged commit 0fb2990 into buildpack/0.4 Jul 29, 2020
@nebhale nebhale deleted the windows-buildpacks branch July 29, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move windows related buildpack API changes to buildpack/0.4
2 participants