Asset Packages - Platform #228
Conversation
This change updates the platform specification with asset package support. [#201] Signed-off-by: Ben Hale <bhale@vmware.com>
| @@ -832,6 +832,12 @@ The following variables SHOULD be set in the lifecycle execution environment and | |||
|
|
|||
| The platform SHOULD NOT assume any other stack-provided environment variables are inherited by the buildpack. | |||
|
|
|||
| ##### Builder-Provided Variables | |||
There was a problem hiding this comment.
Is it possible for a platform to provide this variable even if it doesn't use builders?
There was a problem hiding this comment.
I agree that calling out builders specifically here is inapproriate. Maybe Platform-Provided Variables? Although one could argue that stack-provided and user-provided variables are also platform-provided in a sense.
There was a problem hiding this comment.
| ##### Builder-Provided Variables | |
| ##### Platform-Provided Variables |
I can't come up with something better, so I'm 👍 on that change.
| @@ -832,6 +832,12 @@ The following variables SHOULD be set in the lifecycle execution environment and | |||
|
|
|||
| The platform SHOULD NOT assume any other stack-provided environment variables are inherited by the buildpack. | |||
|
|
|||
| ##### Builder-Provided Variables | |||
| The following variables MAY be set in the lifecycle execution environment and SHALL be directly inherited by the buildpack without modification: | |||
There was a problem hiding this comment.
| The following variables MAY be set in the lifecycle execution environment and SHALL be directly inherited by the buildpack without modification: | |
| The following variables MAY be set in the lifecycle execution environment and SHALL be directly inherited by the buildpack without modification, if also supported by the buildpack API: |
There was a problem hiding this comment.
@natalieparellano I think you are right that we need a caveat here but maybe we want something more generic? It seems weird to apply this specific carve-out to an entire table that could be extended to include more variables.
There was a problem hiding this comment.
Makes sense! I modified my suggestion.
|
Since this is not making it into the next spec release, we're moving this into draft for now. More discussion to follow. |
This change updates the platform specification with asset package support.
[#201]
Signed-off-by: Ben Hale bhale@vmware.com