Adds api to buildpack.toml schema #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Young <myoung@pivotal.io> Signed-off-by: Emily Casey <ecasey@pivotal.io>
sclevine
requested changes
Sep 18, 2019
Signed-off-by: Emily Casey <ecasey@pivotal.io>
jkutner
approved these changes
Sep 20, 2019
hone
reviewed
Sep 20, 2019
| - MUST describe the implemented buildpack API. | ||
| - SHALL indicate compatibility with a given lifecycle according to the following rules: | ||
| - When `<major>` is `0`, the buildpack is only compatible with lifecycles implementing that exact buildpack API. | ||
| - When `<major>` is greater than `0`, the buildpack is only compatible with lifecycles implementing buildpack API `<major>.<minor>`, where `<major>` of the lifecycle equals `<major>` of the buildpack and `<minor>` of the lifecycle is greater than or equal to `<minor>` of the buildpack. |
There was a problem hiding this comment.
Does this mean that if you specify api = 1 that it isn't compatible with 1.1 b/c api = 1 is equivalent to api = 1.0?
There was a problem hiding this comment.
If the buildpack specifies api = 1 it IS compatible with lifecycle where buildpack = 1.1 b/c 1 (the minor of the lifecycle) is greater than or equal to 0 (the implied minor 0 of the buildpack)
There was a problem hiding this comment.
happy to reword if it's confusing
There was a problem hiding this comment.
I think that matches what's written. What about in the inverse case? api = 1.1 would not work on a lifecycle that sets buildpack = 1.0, right?
There was a problem hiding this comment.
Just chatted with @ekcasey and she confirmed the above.
sclevine
approved these changes
Sep 24, 2019
nebhale
approved these changes
Sep 24, 2019
hone
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Micah Young myoung@pivotal.io
Signed-off-by: Emily Casey ecasey@pivotal.io