Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new Heroku builder images in the example builders lists #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edmorley
Copy link

@edmorley edmorley commented Oct 3, 2023

The heroku/buildpacks:* builders have been replaced by heroku/builder:* and the former are about to be deprecated.

See:
https://github.com/heroku/cnb-builder-images/blob/main/README.md
buildpacks/pack#1924

@edmorley edmorley force-pushed the update-heroku-builder-examples branch from d452916 to 18241fd Compare October 3, 2023 13:20
@edmorley
Copy link
Author

edmorley commented Oct 5, 2023

cc @jromero - I think you might be the best person to review given recent the git log (I'm not able to select you as a reviewer via the GitHub reviewers interface since that can only be accessed by users with maintainer access).

@jjbustamante
Copy link
Member

Hi @edmorley

I know it is unrelated to your change, but could you update the .github/workflows/test.yaml with a new runner? from what I can see we are using a very old one and the tests are not running.

Test: .github#L1
The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

The `heroku/buildpacks:*` builders have been replaced by `heroku/builder:*`
and the former are about to be deprecated.

See:
https://github.com/heroku/cnb-builder-images/blob/main/README.md
buildpacks/pack#1924
Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@edmorley edmorley force-pushed the update-heroku-builder-examples branch from 1eef526 to 571e631 Compare March 12, 2024 21:50
@edmorley
Copy link
Author

@jjbustamante Done - could you re-approve the GHA workflow? :-)

@jjbustamante
Copy link
Member

Oh man, this thing is too old.

It looks like they moved catlin to its repo now.

I tried to run the same commands we are running in the workflow.

➜  tektoncd git clone git@github.com:tektoncd/catlin.git
Cloning into 'catlin'...
warning: templates not found in /Users/juanbustamante/.git_templates
remote: Enumerating objects: 7687, done.
remote: Counting objects: 100% (909/909), done.
remote: Compressing objects: 100% (488/488), done.
remote: Total 7687 (delta 463), reused 755 (delta 386), pack-reused 6778
Receiving objects: 100% (7687/7687), 11.82 MiB | 6.86 MiB/s, done.
Resolving deltas: 100% (3200/3200), done.
Updating files: 100% (3443/3443), done.
➜  tektoncd cd catlin/cmd/catlin
➜  catlin git:(main) go get github.com/tektoncd/catlin/cmd/catlin
go: downloading go.uber.org/zap v1.27.0
...
  • Maybe we can change this line with tektoncd/catlin
  • And these ones with
cd catlin/cmd/catlin
go get github.com/tektoncd/catlin/cmd/catlin

@edmorley
Copy link
Author

edmorley commented Apr 8, 2024

@jjbustamante I think we should just archive this repo at this point, personally :-)

@edmorley edmorley closed this Apr 8, 2024
@edmorley edmorley deleted the update-heroku-builder-examples branch April 8, 2024 12:08
@edmorley edmorley restored the update-heroku-builder-examples branch May 8, 2024 14:34
@edmorley edmorley reopened this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants