Add secondary button config to store #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnman
requested changes
Jan 26, 2023
|
|
||
| function addButtons(options: StorefrontProviderOptions, apps: PlatformApp[]): PlatformApp[] { | ||
| if (options.primaryButton || Array.isArray(options.secondaryButtons)) { | ||
| return apps.map((app) => ({ |
There was a problem hiding this comment.
Shouldn't this be the other way around?
If an app specifies a primary or secondary button then we don't override it with the default buttons.
If a common primary button is defined don't we need the same logic (i.e. pass the app to whatever action id is specified)?
There was a problem hiding this comment.
the first if just checks if there are any options set before processing, I have update to maintain existing primary or secondary if an app has them
johnman
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.