Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handwrite: cli: Add optional params for filename, family name and font style #62

Merged
merged 9 commits into from
Nov 26, 2021

Conversation

sakshamarora1
Copy link
Member

No description provided.

@yashlamba
Copy link
Member

Dependency issue: mkdocstrings/mkdocstrings#295

Copy link
Member

@yashlamba yashlamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things:

  1. Run this:
    handwrite excellent.jpg . --filename y o --family yo --style ho
    then again same, the new file is yo-default, is it expected?

image
This is when installing the output of the above.

@sakshamarora1
Copy link
Member Author

sakshamarora1 commented Nov 21, 2021

@yashlamba

  1. When we find that the font file already exists, we append its corresponding config file name used (I guess we did to accommodate the multiple config cases we are removing in this PR). Will remove the first if-else block and then it will create the consequent files like yo (1).ttf, yo (1) (1).ttf, and so on.
    https://github.com/cod-ed/handwrite/blob/8784a45868e0e2ae369d0f0c74fb9091f4eb4eb1/handwrite/svgtottf.py#L155-L164
  2. What's the context here?

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handwrite: cli: Add optional params to modify font metadata
2 participants