Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt for PHP 8 and missing arginfo #42

Merged
merged 2 commits into from Feb 21, 2021
Merged

adapt for PHP 8 and missing arginfo #42

merged 2 commits into from Feb 21, 2021

Conversation

remicollet
Copy link
Contributor

Using bukka/phpc#1

PHP_VERSION : 8.0.0beta2

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   16
---------------------------------------------------------------------

Number of tests :  144               144
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :  144 (100.0%) (100.0%)
---------------------------------------------------------------------
Time taken      :    1 seconds
=====================================================================

remicollet
remicollet commented Aug 25, 2020
View reviewed changes
fann_connection.c
PHP_ME(FANNConnection, getWeight, NULL, ZEND_ACC_PUBLIC)
PHP_ME(FANNConnection, getFromNeuron, arginfo_fannconnection_void, ZEND_ACC_PUBLIC)
PHP_ME(FANNConnection, getToNeuron, arginfo_fannconnection_void, ZEND_ACC_PUBLIC)
PHP_ME(FANNConnection, getWeight, arginfo_fannconnection_void, ZEND_ACC_PUBLIC)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arginfo are now mandatory for all functions/methods

@xvilo
Copy link

xvilo commented Jan 28, 2021

@remicollet can you let me know what the status is of this PR?

@remicollet
Copy link
Contributor Author

@xvilo no, need to ask project owner, so @bukka

@bukka bukka merged commit f7bfc3d into bukka:master Feb 21, 2021
@bukka
Copy link
Owner

bukka commented Feb 21, 2021

Sorry was busy. Seems to work fine so it's merged now. Will need to do a bit more testing and then will prepare release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@remicollet @xvilo @bukka