Expressions #74
Merged
Expressions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/yahoo/bullet/postaggregations/ComputationStrategy.java
|
ready for re-review. i've undoubtedly missed something |
akshaisarma
requested changes
May 26, 2020
src/main/java/com/yahoo/bullet/query/postaggregations/Culling.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yahoo/bullet/query/postaggregations/Computation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yahoo/bullet/query/postaggregations/Having.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yahoo/bullet/query/postaggregations/OrderBy.java
Outdated
Show resolved
Hide resolved
src/main/java/com/yahoo/bullet/querying/aggregations/QuantileSketchingStrategy.java
Outdated
Show resolved
Hide resolved
| return null; | ||
| } | ||
|
|
||
| private static double[] generatePoints(double start, double end, double increment, int maxPoints, int rounding) { |
There was a problem hiding this comment.
Share this with the code in QuantileSketch? Perhaps in utilities and make the signature have a function instead of the increment so we can generalize to logarithmic, exponential and whatever else point generation?
src/main/java/com/yahoo/bullet/querying/aggregations/grouping/GroupData.java
Outdated
Show resolved
Hide resolved
| TypedObject leftValue = left.evaluate(record); | ||
| TypedObject rightValue = right.evaluate(record); | ||
| Type subType = leftValue.getType(); | ||
| return new TypedObject(Type.BOOLEAN, ((List<? extends Serializable>) rightValue.getValue()).stream().anyMatch(o -> leftValue.compareTo(new TypedObject(subType, o)) > 0)); |
There was a problem hiding this comment.
Can't remember but do these work properly for vacuous truth checks? X > ANY([]) or X > ALL([])? I remember having to do stuff to handle this properly.
akshaisarma
reviewed
May 27, 2020
| @@ -90,6 +90,6 @@ public void testNumericExtraction() { | |||
| Assert.assertNull(Utilities.extractFieldAsNumber("id", record)); | |||
| Assert.assertEquals(Utilities.extractFieldAsNumber("foo", record), ((Number) 1.20).doubleValue()); | |||
| Assert.assertEquals(Utilities.extractFieldAsNumber("bar", record), ((Number) 42).longValue()); | |||
| Assert.assertEquals(Utilities.extractFieldAsNumber("map_field.foo", record), ((Number) 21).doubleValue()); | |||
| Assert.assertNull(Utilities.extractFieldAsNumber("map_field.foo", record)); | |||
There was a problem hiding this comment.
Should we just remove the addMap instead since this is functionality we no longer support?
There was a problem hiding this comment.
So I kept this test here to show that that functionality doesn't exist anymore.
src/test/java/com/yahoo/bullet/windowing/SlidingRecordTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/yahoo/bullet/storage/MemoryStorageManagerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/yahoo/bullet/querying/aggregations/GroupStrategyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/yahoo/bullet/querying/aggregations/QuantileSketchingStrategyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/yahoo/bullet/querying/aggregations/TupleSketchingStrategyTest.java
Outdated
Show resolved
Hide resolved
| Assert.assertEquals(GroupData.getResultName(operation), GroupOperation.GroupOperationType.COUNT.getName() + | ||
| GroupData.NAME_SEPARATOR + "foo"); | ||
| operation = new GroupOperation(GroupOperation.GroupOperationType.COUNT, null, "bar"); | ||
| Assert.assertEquals(GroupData.getResultName(operation), "bar"); |
There was a problem hiding this comment.
Can we add a test for the new fieldAliases added to GroupData?
src/test/java/com/yahoo/bullet/querying/partitioning/SimpleEqualityPartitionerTest.java
Outdated
Show resolved
Hide resolved
akshaisarma
reviewed
Jun 3, 2020
| return new TypedObject(record.extractField(identifier)); | ||
| public static double[] generatePoints(double start, Function<Double, Double> generator, int numberOfPoints, int rounding) { | ||
| double[] points = new double[numberOfPoints]; | ||
| double begin = start; |
| @Slf4j | ||
| public class GroupAll implements Strategy { | ||
| public class GroupStrategy implements Strategy { |
akshaisarma
previously approved these changes
Jun 3, 2020
akshaisarma
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.