Fixes #16 #17
Fixes #16 #17
Conversation
| @@ -36,7 +36,8 @@ public FilterRule(String input, Map configuration) throws ParsingException { | |||
|
|
|||
| @Override | |||
| public boolean consume(BulletRecord record) { | |||
| if (!specification.isAcceptingData() || !specification.filter(record)) { | |||
| // If rule is expired, not accepting data or does not match filters, don't consume... | |||
| if (isExpired() || !specification.isAcceptingData() || !specification.filter(record)) { | |||
There was a problem hiding this comment.
It might be over-optimizing, but you could add a boolean member variable to AbstractRule, maybe called "expired", and check this first in isExpired() before doing the system call. I think the 'System.currentTimeMillis()' system call is going to be an order of magnitude slower than checking a member variable. So you could avoid the System call for all the times isExpired() is called after the rule has expired but before the next tick occurs...
There was a problem hiding this comment.
Thought about adding that but since a query generally runs longer than a tick, the number of the times we would check this boolean (and do the time check) while the query is running would be >> the number of times we don't do the time check after the query has expired and before the tick.
No description provided.