Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhooks::Outgoing::EndpointSupport doesn't enforce valid_event_types. #407

Open
andrewculver opened this issue Aug 16, 2023 · 1 comment · May be fixed by #429
Open

Webhooks::Outgoing::EndpointSupport doesn't enforce valid_event_types. #407

andrewculver opened this issue Aug 16, 2023 · 1 comment · May be fixed by #429
Assignees
@gazayas

Comments

@andrewculver
Copy link
Contributor

No description provided.

@andrewculver
Copy link
Contributor Author

andrewculver commented Aug 16, 2023 •
edited

Downstream I fixed this by adding the following to Webhooks::Outgoing::Endpoint:

validates :event_type_ids, inclusion: {in: -> (endpoint) { endpoint.valid_event_types.map(&:id) }}

@gazayas gazayas linked a pull request Aug 17, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gazayas gazayas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add validation for event_type_ids for outgoing webhooks bullet-train-co/bullet_train-core
2 participants
@andrewculver @gazayas