Add validation for event_type_ids
for outgoing webhooks
#429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #407.
I was able to confirm the fix provided in the issue works by ejecting the webhooks controller and customizing the valid event types.
What I did in the screenshots here:
valid_event_types
to only allowmembership
event types@endpoint.valid?
yieldstrue
in the create actionThe record is also valid when the event types field is left blank.