Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TurboDeviseController fix #101

Merged
merged 1 commit into from Feb 8, 2023
Merged

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Feb 8, 2023

Closes #99.

@adampal found out that the gem that was giving us trouble is responders

Original Fix before responders v.3.1.0

The TurboDeviseController fix we have in place is a fix I saw in multiple places:
Example 1
Example 2
Example 3

rendering_options is now obsolete

However, it is outdated because rendering_options was removed from the repository.

rendering_options was initially added in this PR and looked like this:

def rendering_options
  if options[:render]
    options[:render]
  else
    { action: default_action }
  end
end

This has simply been named to error_rendering_options as you can see in this PR, so I went ahead and changed the name and the tests are passing without an issue.

@adampal adampal merged commit 07cfe1c into main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleCI consistently raising undefined local variable or method error
2 participants