-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Run starter repo tests in GitHub Actions #700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! This sounds good to me. GitHub Actions is as much magic incantations as CircleCI to me so I don't have opinions or advice on the code if need be.
cache: 'yarn' | ||
cache-dependency-path: tmp/starter/yarn.lock | ||
|
||
- name: Link Core Repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have Checkout This Repo
on line 49, maybe we should change this to Link This Repo
instead? Super minor nitpick, just thought I'd mention it.
Since CircleCI is automatically failing due to billing issues I disabled it on this repo in the same way as described here: bullet-train-co/bullet_train#1206 (comment) |
This makes it so that we run the test suites from the starter repo in GitHub Actions.
CircleCI is giving us trouble (again!), so it may be time to ditch it for this repo.