Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run starter repo tests in GitHub Actions #700

Merged
merged 11 commits into from
Nov 29, 2023

Conversation

jagthedrummer
Copy link
Contributor

@jagthedrummer jagthedrummer commented Nov 28, 2023

This makes it so that we run the test suites from the starter repo in GitHub Actions.

CircleCI is giving us trouble (again!), so it may be time to ditch it for this repo.

CleanShot 2023-11-28 at 11 22 47

@jagthedrummer jagthedrummer marked this pull request as ready for review November 28, 2023 17:24
Copy link
Contributor

@kaspth kaspth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This sounds good to me. GitHub Actions is as much magic incantations as CircleCI to me so I don't have opinions or advice on the code if need be.

cache: 'yarn'
cache-dependency-path: tmp/starter/yarn.lock

- name: Link Core Repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have Checkout This Repo on line 49, maybe we should change this to Link This Repo instead? Super minor nitpick, just thought I'd mention it.

@jagthedrummer
Copy link
Contributor Author

Since CircleCI is automatically failing due to billing issues I disabled it on this repo in the same way as described here: bullet-train-co/bullet_train#1206 (comment)

@jagthedrummer jagthedrummer merged commit 2d67633 into main Nov 29, 2023
30 checks passed
@jagthedrummer jagthedrummer deleted the jeremy/github-starter-repo-tests branch November 29, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants