Add concerns for different namespacing options #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511.
We have the following line in the
RoutesFileManipulator.bullet_train-core/bullet_train-super_scaffolding/lib/scaffolding/routes_file_manipulator.rb
Line 397 in 9227d14
This doesn't cover all of the namespace options available though, so I pulled this out of the main
ifstatement so it covers all situations. Now any concerns passed as options to the Super Scaffolding command should be scaffolded to the routes being generated.Side Note
I added the GitHub Actions workflow so we can check the tests for Super Scaffolding here.