Update _address_field.html.erb fixes #809 #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure dependent field updates on address are contained to the correct turbo frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure dependent field updates on address are contained to the correct turbo frame.
Currently we're using the parent form to set the selector on the dependent fields. This is an issue if we want multiple address fields on the one model. This changes the selector to use the
address_formso it's scoped down to just the individual address in question. With this change the javascript all does the right thing when changing countries on different addresses within the same form.While this change doesn't immediately make it possible to add multiple address it seems like good hygiene to keep things appropriately scoped. And it's fairly trivial to add an
address_typecolumn to the Address model in applications that require multiple addresses on the same model.