Fix: Don't rely on jquery when detecting user timezone #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently remove the global `jQuery` alias `$` in an effort to work towards eliminationg jquery completely. This PR changes the timezone detection that happens when we edit user details to not rely on jQuery at all, global or otherwise. Fixes: bullet-train-co/bullet_train#1504
jagthedrummer
commented
Jun 3, 2024
Comment on lines
-70
to
-73
| // update the select2 as well. is there a better way to handle this? | ||
| // why don't _they_ handle this for us? | ||
| $("#select2-user_time_zone-container").attr('title', $option.text()); | ||
| $("#select2-user_time_zone-container").text($option.text()); |
There was a problem hiding this comment.
These lines don't seem to be necessary anymore. Setting the value attribute on the select element itself (#user_time_zone) now seems to make select2 automatically update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently remove the global
jQueryalias$in an effort to work towards eliminationg jquery completely. This PR changes the timezone detection that happens when we edit user details to not rely on jQuery at all, global or otherwise.Fixes: bullet-train-co/bullet_train#1504