Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Update all Bundler dependencies (2022-05-10) #140

Merged
merged 1 commit into from
May 14, 2022

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 10, 2022

This is your daily update of all Bundler dependencies. Please take a good look at what changed and the test results before merging this pull request.

What changed?

↗️ stripe (indirect, 5.55.0 → 6.0.0, major) · Repo · Changelog · Diff

↗️ actioncable (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ actionmailbox (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog

↗️ actionmailer (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ actionpack (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ actiontext (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ actionview (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ activejob (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ activemodel (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ activerecord (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ activestorage (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ activesupport (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ aws-partitions (indirect, 1.586.0 → 1.587.0, minor) · Repo

✳️ rails (7.0.2.4 → 7.0.3, minor) · Repo · Diff

↗️ railties (indirect, 7.0.2.4 → 7.0.3, minor) · Repo · Changelog · Diff

↗️ regexp_parser (indirect, 2.3.1 → 2.4.0, minor) · Repo · Changelog · Diff

↗️ strscan (indirect, 3.0.1 → 3.0.2, patch) · Repo · Changelog · Diff


Depfu Status

Depfu will only send you the next scheduled PR once you merge or close this one.

All Depfu comment commands
@​depfu refresh
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu depfu bot added the depfu label May 10, 2022
@andrewculver
Copy link
Contributor

@gazayas Not sure why this is failing, but I'm thinking we should amend the schema check to output the git diff db/schema.rb if there are differences. Would make it easier to see what's happening here in CI.

@gazayas
Copy link
Contributor

gazayas commented May 13, 2022

@andrewculver I updated our db schema check, and it looks like integers are being changed to bigints with the update to Rails 7.0.3.
I looked through 7.0.3.'s changelogs but haven't found anything yet, so I'll keep looking to see if I can find what's up.

Here are the logs from the test PR #147:

rails db:migrate made a change to your database's schema.
Please make sure your database is updated locally before pushing to CircleCI:
diff --git a/db/schema.rb b/db/schema.rb
index edf2fe2..b17b497 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -27,7 +27,7 @@ ActiveRecord::Schema[7.0].define(version: 2022_04_18_034147) do
     t.string "name", null: false
     t.text "body"
     t.string "record_type", null: false
-    t.integer "record_id", null: false
+    t.bigint "record_id", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
     t.index ["record_type", "record_id", "name"], name: "index_action_text_rich_texts_uniqueness", unique: true
@@ -56,7 +56,7 @@ ActiveRecord::Schema[7.0].define(version: 2022_04_18_034147) do
   end
 
   create_table "active_storage_variant_records", force: :cascade do |t|
-    t.integer "blob_id", null: false
+    t.bigint "blob_id", null: false
     t.string "variation_digest", null: false
     t.index ["blob_id", "variation_digest"], name: "index_active_storage_variant_records_uniqueness", unique: true
   end
@@ -102,8 +102,8 @@ ActiveRecord::Schema[7.0].define(version: 2022_04_18_034147) do
   end
 
   create_table "memberships_reassignments_assignments", force: :cascade do |t|
-    t.integer "membership_id", null: false
-    t.integer "scaffolding_completely_concrete_tangible_things_reassignments_i"
+    t.bigint "membership_id", null: false
+    t.bigint "scaffolding_completely_concrete_tangible_things_reassignments_i"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
     t.index ["membership_id"], name: "index_memberships_reassignments_assignments_on_membership_id"
@@ -111,7 +111,7 @@ ActiveRecord::Schema[7.0].define(version: 2022_04_18_034147) do
   end
 
   create_table "memberships_reassignments_scaffolding_completely_concrete_tangi", force: :cascade do |t|
-    t.integer "membership_id", null: false
+    t.bigint "membership_id", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
     t.index ["membership_id"], name: "index_tangible_things_reassignments_on_membership_id"
@@ -172,7 +172,7 @@ ActiveRecord::Schema[7.0].define(version: 2022_04_18_034147) do
   end
 
   create_table "scaffolding_absolutely_abstract_creative_concepts", force: :cascade do |t|
-    t.integer "team_id", null: false
+    t.bigint "team_id", null: false
     t.string "name"
     t.text "description"
     t.datetime "created_at", null: false
@@ -191,7 +191,7 @@ ActiveRecord::Schema[7.0].define(version: 2022_04_18_034147) do
   end
 
   create_table "scaffolding_completely_concrete_tangible_things", force: :cascade do |t|
-    t.integer "absolutely_abstract_creative_concept_id", null: false
+    t.bigint "absolutely_abstract_creative_concept_id", null: false
     t.string "text_field_value"
     t.string "button_value"
     t.string "cloudinary_image_value"

@gazayas
Copy link
Contributor

gazayas commented May 14, 2022

@andrewculver I think I found something related in this rails issue. Running rails app:update on the current branch and then rails db:migrate will change everything to bigint. I'm not sure if it's worth putting in the time to make a PR (the fix for the SQLite adapter seems pretty short) but I'll at least mention the issue we're having.

@andrewculver
Copy link
Contributor

@gazayas I was able to recreate this issue on a new Rails repository, so I've opened an issue at rails/rails#45093.

@gazayas
Copy link
Contributor

gazayas commented May 14, 2022

@andrewculver Awesome, I'll be sure to keep an eye out on it.

@andrewculver
Copy link
Contributor

Seems this is evidence of a bug fix, not a new bug, so I'm going to go ahead and merge this!

@andrewculver andrewculver merged commit 6f33621 into main May 14, 2022
@depfu depfu bot deleted the depfu/batch_all/2022-05-10 branch May 14, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants