Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacky bug fix for Rails 7.1.0 #56

Closed
wants to merge 2 commits into from
Closed

Hacky bug fix for Rails 7.1.0 #56

wants to merge 2 commits into from

Conversation

jagthedrummer
Copy link
Contributor

Fixes #54 (but I'm not sure it fixes it in a good way).

It looks like something about ActionView changed with Rails 7.1.0, but I haven't been able to spot exactly what from the Changelog.

I'm not confident that this is a fix that we actually want to use. I'm mainly submitting this PR to document what I've found, and I'm hoping that someone will have an idea for a better fix.

@jagthedrummer
Hacky bug fix for Rails 7.1.0
923479c 
Fixes #54 (but I'm not sure it fixes it in a good way).

It looks like something about `ActionView` changed with Rails `7.1.0`,
but I haven't been able to spot exactly what from the Changelog.

I'm not confident that this is a fix that we actually want to use. I'm
mainly submitting this PR to document what I've found, and I'm hoping
that someone will have an idea for a better fix.
@jagthedrummer jagthedrummer mentioned this pull request Oct 9, 2023
Merged
@jagthedrummer
Copy link
Contributor Author

jagthedrummer commented Oct 9, 2023 •
edited
Loading

The tests failing in CI aren't failing for me locally...

Failure:
Jbuilder::Schema::GemLoadingTest#test_loads_when_put_after_jbuilder [/home/runner/work/jbuilder-schema/jbuilder-schema/test/jbuilder/schema/gem_loading_test.rb:7]:
Expected "" to include "type: object".

rails test home/runner/work/jbuilder-schema/jbuilder-schema/test/jbuilder/schema/gem_loading_test.rb:4

And, of course, standardrb doesn't like the use of eval.

@jagthedrummer jagthedrummer mentioned this pull request Oct 9, 2023
Closed
@kaspth
Copy link
Contributor

kaspth commented Oct 9, 2023

I just fixed this over in #57 — it's still sorta hacky, but it does skip eval and expands our CI to several Rails versions too.

@kaspth kaspth closed this Oct 9, 2023
@kaspth kaspth deleted the jeremy/rails-7.1.0-bug-fix branch October 9, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update for Rails 7.1.0
2 participants
@jagthedrummer @kaspth