Remove partial shorthand _p and deprecate p
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspth
commented
Jul 3, 2022
| @@ -24,12 +24,19 @@ def with_nice_partials_t_prefix(lookup_context, block) | |||
| end | |||
| end | |||
|
|
|||
| require "active_support/deprecation" | |||
| NicePartials::DEPRECATOR = ActiveSupport::Deprecation.new("1.0", "nice_partials") | |||
There was a problem hiding this comment.
@andrewculver not sure what version number we want in here, could be something in the 0.x range too. Your pick 😄
There was a problem hiding this comment.
1.0 is good. That’s where we’re heading for sure.
kaspth
added a commit
that referenced
this pull request
Jul 3, 2022
|
Looks like the backtrace is getting tripped up I'll give it one shot and then just recommend swapping to |
kaspth
force-pushed
the
remove-partial-shorthands
branch
from
e304d9c
to
f281083
Compare
|
Meh, can't figure out and it might be something with an interaction in the depending libraries that real apps might not see. |
kaspth
added a commit
that referenced
this pull request
Jul 4, 2022
* Rename `content` to `partial` Fixes #36 We're keeping the `_p` and `p` for now, to decide on separately. * Remove `partial` shorthand `_p` and deprecate `p` (#39) * Cut _p shorthand trial short by my own hands * Deprecate p shorthand in favor of partial Co-authored-by: Kasper Timm Hansen <kaspth@gmail.com>
kaspth
added a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
By default the deprecator logs to the console, put for ferreting errant
pcalls in CI, users could swap to raising: