Wrapping up t-prefix fix #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once bullet-train-co/bullet_train-core#331 has been merged, we can remove d43289a and merge this to ship a new Nice Partials release. |
kaspth
force-pushed
the
fix-t-prefix-part-2
branch
from
d43289a
to
d690cf0
Compare
|
I rebased out the in-flight Super Scaffolding testing, so now I'll wait for the build and then we can go. |
This fixes a change I made to our t-prefixes that broke things: overriding `ActionView::Base#capture` meant that we'd fire on helper calls too — and extract from their block location. Note: we're leveraging Rails 6.1+'s `@current_template.virtual_path` to avoid needing to muck with block source_locations or view_paths, Rails has already figured that out for us.
kaspth
force-pushed
the
fix-t-prefix-part-2
branch
from
09919ae
to
03d14be
Compare
`t` might be called often on a page and in a nested loop these needless String allocations could add up. Since they're so easy to fix, let's do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #86 using a different branch since a client project is relying on that branch now.
Closes #86.