Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header element, unable to make mobile sticky header #41

Closed
1 of 3 tasks
MagicAardvark opened this issue May 5, 2016 · 1 comment · Fixed by #42
Closed
1 of 3 tasks

Header element, unable to make mobile sticky header #41

MagicAardvark opened this issue May 5, 2016 · 1 comment · Fixed by #42
Assignees
@asibilia
Milestone
1.0

Comments

@MagicAardvark
Copy link
Contributor

Note: for support questions, please use one of these channels: Chat: BullhornOSS Gitter

I'm submitting a ...
  • bug report
  • feature request
  • question about the decisions made in the repository
What is the current behavior?

section.primary is transparent

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via

https://plnkr.co or similar. (TODO - make a starter plnkr)

What is the expected behavior?

The top bar should not be transparent when position:fixed

What is the motivation / use case for changing the behavior?

I would like to make a sticky header in mobile which is made up of 3 sections

[BTN] [HEADER] [BTN] <- should be sticky to top (position:fixed)
[SECTION] <- should slide under header when user scrolls
[TAB SECTION] <- should become sticky under HEADER (becomes fixed at certain point)

The top bar uses the section.primary class and currently has no background color so it is transparent when the section content slides under it.

What I would like is the background color to also be applied to section.primary to allow me to have this functionality.

Please tell us about your environment:
  • Angular version: 2.0.0-beta.X
  • Ionic 2
  • Browser: all
Other information

screen shot 2016-05-05 at 10 32 32 am
screen shot 2016-05-05 at 10 32 46 am
@jgodi
Copy link
Contributor

jgodi commented May 5, 2016

Sounds like an Alec issue :)

@jgodi jgodi added this to the 1.0 milestone May 5, 2016
@jgodi jgodi added the feature label May 5, 2016
@asibilia asibilia mentioned this issue May 5, 2016
Merged
7 tasks
@jgodi jgodi closed this as completed in #42 May 5, 2016
jgodi pushed a commit that referenced this issue May 5, 2016
@jgodi
fix(headers): Fixes SCSS to give section.primary appropriate backgrou…
a36058a 
…nd color, closes #41
bvkimball pushed a commit that referenced this issue May 13, 2016
Merge branch 'master' into f/picker
c22bcd2 
* master:
  chore(loading): Fixing href for location
  chore(location): Removing base href
  chore(location): Fixing location strategy and e2e tests
  v0.0.7
  chore(cleanup): Cleaning up styling/demos
  chore(NG2 RC1): Update to NG2 RC.1, closes #35 (#46)
  feat(calendar): Implementing DatePicker and TimePicker, closes #2
  feat(table): Adds table element and documentation, closes #17
  fix(headers): Fixes SCSS to give section.primary appropriate background color, closes #41
  v0.0.6
  feat(list): Adds list component and documentation, closes #11 (#40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asibilia asibilia

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

fix(headers): Fixes SCSS, closes #41 bullhorn/novo-elements
3 participants
@jgodi @asibilia @MagicAardvark