fix(Select): Provide an optional fix directive for <novo-select> elements #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents that adjusts checkboxes after a value update
|
Visit the preview URL for this PR (updated for commit c063f6c): https://novo-elements--pr1560-f-select-checkbox-di-e3jx177c.web.app (expires Wed, 03 Jul 2024 19:33:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
ndickerson
previously approved these changes
Jun 24, 2024
dvoegelin
previously approved these changes
Jun 24, 2024
ndickerson
previously approved these changes
Jun 26, 2024
ndickerson
approved these changes
Jun 28, 2024
dvoegelin
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusts checkboxes inside of the overlay when its value was updated via some external process.
Since this change may be high-impact across all instances, the fix is created as a directive, and should only be applied when the problem has some impact.
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots