Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo): remove angular-cli json file and add it in typescript #930

Merged
merged 1 commit into from Mar 24, 2019
Merged

fix(demo): remove angular-cli json file and add it in typescript #930

merged 1 commit into from Mar 24, 2019

Conversation

charlesabarnes
Copy link
Contributor

@charlesabarnes charlesabarnes commented Mar 23, 2019 •
edited

Description

Follow on from #928

Github pages doesn't seem to agree with the .angular-cli.json file. I removed dependency of the json file and added it via javascript. removes the requirement of server side requests

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

@charlesabarnes charlesabarnes merged commit 15653d3 into master Mar 24, 2019
@charlesabarnes charlesabarnes deleted the f/stackblitzJson branch March 24, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndickerson ndickerson ndickerson approved these changes

@akurtovic akurtovic akurtovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charlesabarnes @ndickerson @akurtovic