Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance handling of invalid UTF-8 sequences in check_numeric_host function #2

Open
coderabbitai bot opened this issue Mar 14, 2024 · 1 comment
Open

Enhance handling of invalid UTF-8 sequences in check_numeric_host function #2

coderabbitai bot opened this issue Mar 14, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2024 •
edited by sporkmonger

Following the discussion in PR #1, there's a consensus on improving the function to gracefully handle invalid UTF-8 sequences. The '�' character used to replace invalid sequences should potentially be filtered out.
@sporkmonger
Copy link
Contributor

sporkmonger commented Mar 14, 2024 •
edited

As mentioned in #1, the from_utf8_lossy function should help filter out invalid unicode sequences in a way that's difficult to use as a detection bypass.

@sporkmonger sporkmonger added the good first issue Good for newcomers label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sporkmonger