Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission checks should use BTreeSet instead of Vec #204

Open
coderabbitai bot opened this issue Mar 11, 2024 · 1 comment
Open

Permission checks should use BTreeSet instead of Vec #204

coderabbitai bot opened this issue Mar 11, 2024 · 1 comment
Labels
good first issue Good first issue for newcomers to the project. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. rust Pull requests that update Rust code

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2024

This issue tracks the suggested improvement to replace with for storing allowed HTTP domains and remote state key prefixes in and functions. This change aims to enhance performance by enabling faster lookups and more efficient permission checks.

Related PR: #202
Comment: #202 (comment)
@sporkmonger sporkmonger changed the title Optimize permission checks using BTreeSet Permission checks should use BTreeSet instead of Vec Mar 12, 2024
@sporkmonger
Copy link
Contributor

The verify_http_domains and verify_remote_state_prefixes functions should take a BTreeSet<String> parameter instead.

@sporkmonger sporkmonger added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. rust Pull requests that update Rust code good first issue Good first issue for newcomers to the project. labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issue for newcomers to the project. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sporkmonger