Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unsafe Calls to Eval() #39

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

michael-lumley
Copy link
Contributor

@michael-lumley michael-lumley commented Nov 11, 2020

closes #39

Fixes unsafe eval to comply with CSP.

I am using d3-organization-chart in my project, however the naked evals are unsafe and triggering CSP errors. I've updated to avoid use of eval in an unsafe way.

Fix unsafe eval to comply with CSP.
@michael-lumley michael-lumley changed the title Update index.js Remove Unsafe Calls to Eval() Nov 11, 2020
@bumbeishvili
Copy link
Owner

PR code does not replace functionality which eval does, so I have to close it

@michael-lumley
Copy link
Contributor Author

PR code does not replace functionality which eval does, so I have to close it

@bumbeishvili Can you explain the missing functionality? A colleague and I are currently debating what the actual reason for doing the eval() is, and can't seem to figure it out.

@bumbeishvili bumbeishvili reopened this Nov 12, 2020
@michael-lumley
Copy link
Contributor Author

@bumbeishvili Wanted to check in and see what kind of timeline you had in mind here. We're trying to plan around whether we should expect this PR to merge or if we need to fix the problem further downstream. Thanks!

@bumbeishvili
Copy link
Owner

@michael-lumley It looks like you were right, I can go ahead and merge this PR right away.

@bumbeishvili bumbeishvili merged commit 138ed4c into bumbeishvili:master Nov 30, 2020
@bumbeishvili
Copy link
Owner

@michael-lumley also note - I started working on the new version of the org chart (Not sure about the final timeline, since I am doing this, while I work on commercial projects involving org charts, not on my free time )

It will be based on the latest d3.v6 and it will include some new features which were often requested

https://observablehq.com/d/e106c59dbd9f6151

If you want to use it meantime, feel free - https://observablehq.com/d/e106c59dbd9f6151

Here is a list of features which will be implemented - #14

@michael-lumley
Copy link
Contributor Author

@bumbeishvili Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants