Avoid MotionController recreation #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...mmon/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/state/BaseMutableUiState.kt
Outdated
Show resolved
Hide resolved
.../common/src/commonMain/kotlin/com/bumble/appyx/interactions/core/model/BaseAppyxComponent.kt
Outdated
Show resolved
Hide resolved
… calling updateBounds and updateContext. Offset stashed elements in BackStackSlider correctly
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...Main/kotlin/com/bumble/appyx/components/experimental/promoter/ui/PromoterMotionController.kt
Fixed
Show fixed
Hide fixed
...Main/kotlin/com/bumble/appyx/components/experimental/promoter/ui/PromoterMotionController.kt
Fixed
Show fixed
Hide fixed
KovalevAndrey
approved these changes
Sep 8, 2023
Conflicts: CHANGELOG.md appyx-interactions/common/src/commonMain/kotlin/com/bumble/appyx/interactions/core/DraggableChildren.kt appyx-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/composable/AppyxComponent.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass transition bounds outside of
UiContext, avoidMotionControllerrecreation.This should solve the state loss and flickering prominent in desktop/web (also possible in android) when the screen size changes.
Check list
CHANGELOG.mdif required.