-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #145
Refactoring #145
Conversation
bumbummen99
commented
Jan 17, 2022
•
edited
Loading
edited
- Raise required PHP and dependency versions according to supported versions
- Add type hints up to 8.0
- Support Laravel 9
- Use MoneyPHP instead of direct values
- Adjust the general workflow
Raise minimum PHP version according to https://www.php.net/supported-versions.php
test all supported laravel versions
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
============================================
- Coverage 98.41% 93.27% -5.15%
+ Complexity 168 130 -38
============================================
Files 7 5 -2
Lines 442 342 -100
============================================
- Hits 435 319 -116
- Misses 7 23 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Changes according to moneyphp/money@30da0b3
Add MoneyPHP
Keep going! |
I have got to the time to look at all of this yet, but I could make this suggestions, there are more benefits to store amounts in a smaller unit. I have worked with some payment apis and the do work with cents instead of euro. This simplify calculations. Then you round strategy could be used for getters and setters This is a big change but this PR is a big refactor already. EDIT : My bad just saw the vendor Money package is for this usage looking at this branch code. |