core improvements: type predicates, keep AxiosResponse & display human errors #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently discovered functions whose return types are a _type predicate_. It's really useful to transform types (narrowing down types) when you check the type is compatible with what you expect. It adds a bit of clarity in the code by moving the type guards in dedicated functions. (more details of type predicates: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates) _Note: the commit also makes use of a second discovered TS feature, the Type intersection (`&`) to “extend” existing types with more attributes and make them compatible for narrowing. ✨_
The current response interceptor was keeping only the response body of every http API calls. However it's not what we want. We want to be able to check response bodies but also response status for instance. In this commit such need is not very visible (because we don't read any response status) but for later changes it will be good, especially for error handling. The good thing about this change is that it removes the `any` type I had to use to “trick” axios.☺️
3 tasks
scharrier
reviewed
May 4, 2021
This is changing the way we display known invalid definition server errors. It's good to make the presentation of known possible errors more presentable to humans.
scharrier
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor that contains three improvements. Please see details for each in their commit description: