Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs: make the doc parameter optional #485

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented Mar 1, 2024

The GH action doc: input parameter should be optional.

Indeed, since we introduced the directory deploy for Hubs in the CLI, the --doc
parameter became optional for hubs deployments.

This PR makes sure the doc input of the GitHub action is also
optional to be able to deploy a whole directory to a Bump.sh Hub from
the GitHub action too.

@paulRbr paulRbr self-assigned this Mar 1, 2024
paulRbr added a commit to paulRbr/examples that referenced this pull request Mar 1, 2024
This commit is to be removed. It's just a test of the latest changes
of `master` branch of the GH action + the PR I'm working on:
bump-sh/github-action#485
The GH action `doc:` input parameter should be optional.

Indeed, since we introduced the [directory deploy for Hubs in the CLI](bump-sh/cli#462), the `--doc`
parameter became optional for hubs deployments.

This PR makes sure the `doc` input of the GitHub action is also
optional to be able to deploy a whole directory to a Bump.sh Hub from
the GitHub action too.
Copy link
Contributor

@lordinatrice lordinatrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👌

@paulRbr paulRbr merged commit 43005aa into bump-sh:master Mar 1, 2024
4 checks passed
@paulRbr paulRbr deleted the doc-input-optional branch March 1, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants