Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Rename allows on block class to sanitize #59

Open
megasteve19 opened this issue Jan 27, 2024 · 0 comments · May be fixed by #61
Open

[2.x] Rename allows on block class to sanitize #59

megasteve19 opened this issue Jan 27, 2024 · 0 comments · May be fixed by #61
Assignees
@megasteve19
Labels
Breaking Change Backwards incompatible
Milestone
2.0

Comments

@megasteve19
Copy link
Member

Pretty useless issue but it is more correct to use naming sanitize. For now, let's just deprecate and in next major version we can remove it.
@megasteve19 megasteve19 added the Breaking Change Backwards incompatible label Jan 27, 2024
@megasteve19 megasteve19 added this to the 2.0 milestone Jan 27, 2024
@megasteve19 megasteve19 self-assigned this Jan 27, 2024
megasteve19 added a commit that referenced this issue Jan 29, 2024
@megasteve19
This commit resolves following issues
35f4bcb 
- Remove `Data` class (#60)
- Rename `allows` to `sanitize` (#59)
- Virtual attributes, both for EditorPhp and Block (#57)
- Replacing built-in sanitizer with `symfony/html-sanitizer` (#51)
- Remove `$root` and `$model` from `EditorPhp`, which `$root` renamed to `$parent` (#42)

Also lots of refactors and template adjustments.
@megasteve19 megasteve19 linked a pull request Jan 29, 2024 that will close this issue
Draft
@megasteve19 megasteve19 linked a pull request Jan 29, 2024 that will close this issue
[2.x] Resolving issues #61
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@megasteve19 megasteve19

Labels
Breaking Change Backwards incompatible
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

[2.x] Resolving issues bumpcore/editor.php
1 participant
@megasteve19