Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black areas of GIFs can be encoded as transparent #214

Closed
sjudd opened this issue Oct 24, 2014 · 1 comment
Closed

Black areas of GIFs can be encoded as transparent #214

sjudd opened this issue Oct 24, 2014 · 1 comment
Labels
Milestone

Comments

@sjudd
Copy link
Collaborator

sjudd commented Oct 24, 2014

Sample GIF: http://media0.giphy.com/media/ToMjGpFXLkWjpPP58D6/200_d.gif.

This only happens with DiskCacheStrategy.RESULT, which implies the problem is in how the encoder is deciding what the transparent index for each frame should be.

@sjudd sjudd added the bug label Oct 24, 2014
@sjudd sjudd added this to the 3.4 milestone Oct 24, 2014
@sjudd
Copy link
Collaborator Author

sjudd commented Oct 24, 2014

Assuming my understanding is correct, there will never be a perfect solution to this. We can't distinguish between black and transparent reliably. I can get around this case because 443 pixels out of 110307 overall are transparent (.4%), but a half dark grey and half transparent image will probably still break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant