-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFetcher#cancel() should be called on a background thread #278
Comments
@sjudd this seems to be fixed on your branch, did you forget to merge it? |
I tried, but it causes issues with OkHttp. At least that (now relatively old) version of OkHttp seemed to get into a bad state after a few async cancellations of in process requests. |
OkHttp fixes this issue in v2.7.0. https://github.com/square/okhttp/blob/master/CHANGELOG.md |
@floating-cat thanks! Glide |
Obsolete with okhttp3 and v4 |
OkHttp and HttpUrlConnection both trigger strict mode violations when cancel is called on the main thread (See #257, and the TODO in HttpUrlFetcher).
The text was updated successfully, but these errors were encountered: