Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simple calculation mistake #88

Closed
Cosebe opened this issue Aug 12, 2014 · 2 comments
Closed

A simple calculation mistake #88

Cosebe opened this issue Aug 12, 2014 · 2 comments
Labels

Comments

@Cosebe
Copy link

Cosebe commented Aug 12, 2014

I think that code would be changed following

m.postTranslate((int) dx + 0.5f, (int) dy + 0.5f);

to

m.postTranslate((int) (dx + 0.5f), (int) (dy + 0.5f));

in com.bumptech.glide.resize.load.ImageResizer:222

@sjudd
Copy link
Collaborator

sjudd commented Aug 13, 2014

Yes you're definitely correct and that also matches the current platform code where this originated (https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/core/java/android/widget/ImageView.java line 967).

If you'd like to put up a pull request making that change I'd happily accept it. Alternatively I can get to it later this week as well. Thanks for bringing this up!

@sjudd sjudd closed this as completed in ef8d37d Aug 14, 2014
@sjudd
Copy link
Collaborator

sjudd commented Aug 14, 2014

Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants