Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration lib version discrepancies #888

Closed
TWiStErRob opened this issue Jan 13, 2016 · 1 comment
Closed

Integration lib version discrepancies #888

TWiStErRob opened this issue Jan 13, 2016 · 1 comment
Assignees
Milestone

Comments

@TWiStErRob
Copy link
Collaborator

At this time:

  • on 3.0 branch the okhttp lib has 1.4.0 code 10.
  • on master branch the okhttp lib has 2.0.0 code 8.

As far as I know version codes in Android must be incremental, however we can probably get away with it in libraries. Though it would be a nice gesture to keep it consistent.
The code could also be a calculated combination, something like:

major*10000 + minor*100 + patch

So 1.4.0=10400 and 2.0.0=20000. This accounts for any future releases with two digits in any of the versions.

Alternative we can just lock all the android lib version codes to 0 or 1 because it doesn't matter anyway?

@sjudd
Copy link
Collaborator

sjudd commented Jan 28, 2016

Actually I think 0 is the right call, no need to set it if it isn't used, and it's one less thing to screw up with each release.

sjudd added a commit to sjudd/glide that referenced this issue Jan 28, 2016
sjudd added a commit that referenced this issue Jan 28, 2016
Progress towards #888
@sjudd sjudd closed this as completed Jan 28, 2016
TWiStErRob added a commit to TWiStErRob/glide that referenced this issue Feb 7, 2016
TWiStErRob added a commit to TWiStErRob/glide that referenced this issue Feb 7, 2016
sjudd added a commit that referenced this issue Feb 11, 2016
sjudd added a commit that referenced this issue Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants