Api dealing with outdated RequestQueue

[hegazy]

The issue
If we search once or more, then click back, navigate to the app again, and try to search again, no callback methods get called.

why?
If we click back from the activity the API object still the same because it's a static object
and if we navigate again to the activity, we are creating a new RequestQueue in the onCreate() of the FlickrSearchActivity, but in Api.get(requestQueue) the API object is not null so here we are dealing with two request queues and the callback functions is never called.

[sjudd]

Another nice catch, thanks!

Let's solve this slightly differently though. Instead of passing in the request queue to the api, lets have the api own and create its own RequestQueue in its constructor. That way it doesn't have to worry about other people invalidating its dependency.

That would mean we could just pass in a context to obtain the api, which is nicer than the way I have it now anyway. Maybe something like:

public static Api get(Context context) {
...
}

protected Api(Context context) {
this.requestQueue = Volley.newRequestQueue(...);
}

[hegazy]

You are right that saves us from recreating the requestqueue every time we create the activity

[sjudd]

Great thanks for catching and fixing this!

[hegazy]

That's my first contribution to an open source project.
Thanks alot

[sjudd]

Awesome, hopefully the first of many!