This repository has been archived by the owner on May 24, 2022. It is now read-only.
SSL error queue fix #130
Open
SSL error queue fix #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors were not getting cleared from the queue between various OpenSSL function calls. This was causing the error queue to contain misleading information on subsequent calls to SSL_get_error. One degenerate case was incorrect dispatching of errors after a failed SSL_read. Conditions that simply should have lead to another call to SSL_read were being treated as fatal. This was verified while stracing a stud process and seeing read() return with EAGAIN and stud immediately closing the socket fd and logging an SSL_read error.
Conflicts: stud.c
|
I think I've been bitten by this bug. Is there a problem with the patch? #100 is related. |
|
The patch is good. It's been running in production for a few months now and has solved the problem reported in the description. |
mamash
pushed a commit
to TritonDataCenter/pkgsrc-joyent
that referenced
this pull request
Dec 9, 2013
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Feb 20, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors were not getting cleared from the queue between various OpenSSL
function calls. This was causing the error queue to contain misleading
information on subsequent calls to
SSL_get_error.One degenerate case was incorrect dispatching of errors after a failed
SSL_read. Conditions that simply should have lead to another call toSSL_readwere being treated as fatal. This was verified while stracing astud process and seeing
read()return withEAGAINand stud immediatelyclosing the socket fd and logging an
SSL_readerror.