Translate more new level events

bundabrg · Jun 16, 2021 · c413142 · c413142
1 parent 2c9cd7e
commit c413142
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/connector/pom.xml b/connector/pom.xml
@@ -154,7 +154,7 @@
         <dependency>
             <groupId>com.github.GeyserMC</groupId>
             <artifactId>MCProtocolLib</artifactId>
-            <version>dd606b4</version>
+            <version>7248769</version>
             <scope>compile</scope>
             <exclusions>
                 <exclusion>

diff --git a/.../java/org/geysermc/connector/network/translators/java/world/JavaPlayEffectTranslator.java b/.../java/org/geysermc/connector/network/translators/java/world/JavaPlayEffectTranslator.java
@@ -49,6 +49,7 @@ public class JavaPlayEffectTranslator extends PacketTranslator<ServerPlayEffectP
 
     @Override
     public void translate(ServerPlayEffectPacket packet, GeyserSession session) {
+        System.out.println(packet.toString());
         // Separate case since each RecordEffectData in Java is an individual track in Bedrock
         if (packet.getEffect() == SoundEffect.RECORD) {
             RecordEffectData recordEffectData = (RecordEffectData) packet.getData();
@@ -228,6 +229,7 @@ public void translate(ServerPlayEffectPacket packet, GeyserSession session) {
                     effectPacket.setType(LevelEventType.PARTICLE_MOB_BLOCK_SPAWN); // TODO: Check, but I don't think I really verified this ever went into effect on Java
                     break;
                 }
+                case BONEMEAL_GROW_WITH_SOUND: // Note that there is no particle without sound in Bedrock. If you wanted to implement the sound, send a PlaySoundPacket with "item.bone_meal.use" and volume and pitch at 1.0F
                 case BONEMEAL_GROW: {
                     effectPacket.setType(LevelEventType.PARTICLE_CROP_GROWTH);
 
@@ -274,6 +276,10 @@ public void translate(ServerPlayEffectPacket packet, GeyserSession session) {
                     session.sendUpstreamPacket(soundEventPacket);
                     break;
                 }
+                case DRIPSTONE_DRIP: {
+                    effectPacket.setType(LevelEventType.PARTICLE_DRIPSTONE_DRIP);
+                    break;
+                }
                 case ELECTRIC_SPARK: {
                     // Matches with a Bedrock server but doesn't seem to match up with Java
                     effectPacket.setType(LevelEventType.PARTICLE_ELECTRIC_SPARK);

diff --git a/connector/src/main/resources/mappings b/connector/src/main/resources/mappings