Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In geo.py Geo.fetch() top_right and bottom_left seem to be swapped. #26

Closed
devmarcstorm opened this issue Sep 19, 2021 · 3 comments
Closed

Comments

@devmarcstorm
Copy link
Contributor

devmarcstorm commented Sep 19, 2021

In a map oriented to the north, the first coordinate passed to Geo.fetch() is the lower left, and the second coordinate is the upper right of the two coordinates.

The following image shows both coordinates from the documentation in OpenStreetMap.

# top_right and bottom_left coordinates
data = geo.fetch([52.50876180448243, 13.359631043007212], 
                 [52.530116236589244, 13.426532801586827])

image

Maybe I misunderstand the names top_right and bottom_left. Please correct me if this is the case. Otherwise, I would work on a pull request for this issue, which renames the variables.

@LilithWittmann
Copy link
Member

Oh yes seems actually br0ken, sorry, could you create a PR?

@devmarcstorm
Copy link
Contributor Author

Yes, I can do that.

LilithWittmann added a commit that referenced this issue Oct 15, 2021
Fix swapped top_right and bottom_left coordinates in Geo.fetch() (Issue #26)
@LilithWittmann
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants