Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to the test action #42

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

AaronDewes
Copy link
Contributor

  • Test on Python 3.10 too
  • Rename: build -> test
  • If one Python version fails, don't cancel the other tests

I put the python version in quotes because the YAML parser otherwise interprets it as a number, and will think it's 3.10 (3,10 in German notation), which it will pass to actions as 3.1.

- Test on Python 3.10 too
- Rename: build -> test
- If one Python version fails, don't cancel the other tests
Copy link
Contributor

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Shapely does not support Python 3.10 yet.

@AaronDewes
Copy link
Contributor Author

@jugmac00 Yes, only a rc version does, I'm not sure if it would make sense to upgrade to that or wait for it to become stable.

@LilithWittmann LilithWittmann merged commit fdc78d5 into bundesAPI:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants