Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundesanzeiger): Include the raw report contents #88

Merged
merged 3 commits into from
May 13, 2023

Conversation

TrisNol
Copy link
Contributor

@TrisNol TrisNol commented Apr 17, 2023

Hello there,

the Bundesanzeiger lib is awesome (esp. the capability to solve the CAPTCHA). However, it unfortunately only exposes the contents of the report as a text while removing all HTML structures that may be used to parse the yearly results or any other relevant table specifically.

The PR adds the report in it´s raw HTML format as the raw_report attribute. Other functions should not be impacted by this feature.

Looking forward to your feedback

@TrisNol
Copy link
Contributor Author

TrisNol commented May 2, 2023

I assume the failing tests will be fixed with PR 90 since they seem to originate from the presseportal lib.

@wirthual
Copy link
Member

wirthual commented May 5, 2023

I assume the failing tests will be fixed with PR 90 since they seem to originate from the presseportal lib.

Yes, and some other outdated libraries. Can you merge back the current main in your branch?

@wirthual
Copy link
Member

Ready for merge. Thank you @TrisNol

@wirthual wirthual merged commit 389446f into bundesAPI:main May 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants