-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Budgets #385
Comments
Is this like hard limits for sizes? |
@rohit-smpx The idea is just to highlight assets / metrics that are over a predefined budget, similar with the way webpack performance is doing it. I do not have a clear roadmap on how this can be done at the moment, but couple options will be available once v2 will be ready. |
If custom budgets can be specified then this will be pretty great. And if the warning can be turned into an error on CI environments then that will help catch full module imports. |
@rohit-smpx Unexpected module/packages imports can be spotted now, but you have to go over the assets changes and decide if the delta is larger than what you will expect. Other steps to check the modules/packages might be necessary. The bigger the project the longer it will take to decide if there is a problem or not. The budgets will be used just to provide quick feedback if a metric or an asset size is over the budget, but there is no plan to affect the build in any way. The information will be part of the JSON report, so if need it, affecting the build will be a matter of consuming that data and decide what to do with your build based on it. On relative-ci.com we have more options for quick feedback if a budget is failing:
|
@vio could we at least return a |
@jflayhart thanks for your feedback, we will probably need to handle this through an optional argument/option for the cli/webpack-plugin |
This issue is stale because it has been open for 90 days with no activity. |
This issue was closed because it has been inactive for 30 days since being marked as stale. |
This issue is stale because it has been open for 90 days with no activity. |
This issue was closed because it has been inactive for 30 days since being marked as stale. |
The text was updated successfully, but these errors were encountered: