Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budgets #385

Closed
4 of 7 tasks
vio opened this issue Oct 11, 2019 · 10 comments
Closed
4 of 7 tasks

Budgets #385

vio opened this issue Oct 11, 2019 · 10 comments
Labels
feature New feature or request stale

Comments

@vio
Copy link
Member

vio commented Oct 11, 2019

  • utils: add support for budget insights
  • budget for individual assets (similar to: RFC: Webpack Performance Budgets webpack/webpack#3216)
  • ui: Summary - add support for budget info
  • ui: BudgetInsights
  • ui: Totals - add support for budget insights
  • webpack-plugin: Add support for budget config
  • cli: Add support for budget config
@vio vio added the feature New feature or request label Oct 11, 2019
@vio vio added this to Backlog in bundle-stats via automation Oct 11, 2019
@vio vio mentioned this issue Oct 11, 2019
4 tasks
@vio vio removed this from Backlog in bundle-stats Oct 12, 2019
@vio vio added this to To do in relative-ci.com roadmap Nov 13, 2019
@rohit-gohri
Copy link
Contributor

Is this like hard limits for sizes?

@vio
Copy link
Member Author

vio commented Jan 4, 2020

@rohit-smpx The idea is just to highlight assets / metrics that are over a predefined budget, similar with the way webpack performance is doing it.

I do not have a clear roadmap on how this can be done at the moment, but couple options will be available once v2 will be ready.

@rohit-gohri
Copy link
Contributor

If custom budgets can be specified then this will be pretty great. And if the warning can be turned into an error on CI environments then that will help catch full module imports.

@vio
Copy link
Member Author

vio commented Jan 5, 2020

that will help catch full module imports.

@rohit-smpx Unexpected module/packages imports can be spotted now, but you have to go over the assets changes and decide if the delta is larger than what you will expect. Other steps to check the modules/packages might be necessary. The bigger the project the longer it will take to decide if there is a problem or not.

The budgets will be used just to provide quick feedback if a metric or an asset size is over the budget, but there is no plan to affect the build in any way. The information will be part of the JSON report, so if need it, affecting the build will be a matter of consuming that data and decide what to do with your build based on it.

On relative-ci.com we have more options for quick feedback if a budget is failing:

  1. github check status (currently neutral for every job)
  2. Slack/Email notification

@jflayhart
Copy link

@vio could we at least return a exit 0 or something to tell CI tools that it passed? And then if a budget fails, we send exit 1.

@vio
Copy link
Member Author

vio commented Dec 12, 2020

@jflayhart thanks for your feedback, we will probably need to handle this through an optional argument/option for the cli/webpack-plugin

@vio vio pinned this issue Sep 2, 2021
@vio vio moved this from To do to In progress in relative-ci.com roadmap Nov 9, 2021
@vio vio mentioned this issue Dec 17, 2021
@vio vio added this to the v3.4.0 milestone Mar 26, 2022
@vio vio moved this from In progress to Blocked in relative-ci.com roadmap Jul 8, 2022
@vio vio mentioned this issue Dec 10, 2022
@vio vio moved this from Blocked to In progress in relative-ci.com roadmap Dec 22, 2022
@vio vio removed this from the v4.1.0 milestone Jan 11, 2023
@vio vio moved this from In progress to Blocked in relative-ci.com roadmap Mar 8, 2023
@vio vio unpinned this issue Jun 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Sep 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
@vio vio removed the stale label Oct 2, 2023
@vio vio reopened this Oct 2, 2023
Copy link
Contributor

github-actions bot commented Jan 1, 2024

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Jan 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request stale
Projects
No open projects
Development

No branches or pull requests

3 participants