raising Gem::InstallError is the worst possible thing

This code meant that _any_ gem install failure resulted in a message requesting the user to report this "bug" to the Bundler issue tracker. That is very, very not cool, and I had already fixed this issue once before the hook pull request regressed it. :(

lib/bundler.rb

@@ -45,6 +45,7 @@ class GemfileNotFound  < BundlerError; status_code(10) ; end
   class GemNotFound      < BundlerError; status_code(7)  ; end
   class GemfileError     < BundlerError; status_code(4)  ; end
   class InstallError     < BundlerError; status_code(5)  ; end
+  class InstallHookError < BundlerError; status_code(6)  ; end
   class PathError        < BundlerError; status_code(13) ; end
   class GitError         < BundlerError; status_code(11) ; end
   class DeprecatedError  < BundlerError; status_code(12) ; end

lib/bundler/installer.rb

@@ -83,7 +83,7 @@ def install_gem_from_spec(spec, standalone = false)
       FileUtils.rm_rf(Bundler.tmp)
     rescue Exception => e
       # install hook failed
-      raise e if e.is_a?(Gem::InstallError)
+      raise e if e.is_a?(Bundler::InstallHookError)
 
       # other failure, likely a native extension build failure
       Bundler.ui.info ""

lib/bundler/source.rb

@@ -472,7 +472,7 @@ def run_hooks(type, installer)
           if result == false
             location = " at #{$1}" if hook.inspect =~ /@(.*:\d+)/
             message = "#{type} hook#{location} failed for #{installer.spec.full_name}"
-            raise Gem::InstallError, message
+            raise InstallHookError, message
           end
         end
       end